[Intel-gfx] [PATCH 1/7] drm/i915: Prevent using uninitialized MMIO funcs

Daniel Vetter daniel at ffwll.ch
Tue Oct 8 17:23:16 CEST 2013


On Tue, Oct 08, 2013 at 02:38:22PM +0100, Damien Lespiau wrote:
> On Fri, Oct 04, 2013 at 09:22:49PM -0700, Ben Widawsky wrote:
> > For upcoming patches which will have GEN specific MMIO functions, we'll
> > need to initialize the uncore data structure earlier than we do today.
> > 
> > If we do not do this, the following will be problematic:
> > 
> > intel_uncore_sanitize
> > 	intel_disable_gt_powersave
> > 		gen6_disable_rps
> > 			I915_WRITE(GEN6_RC_CONTROL, 0); <--- MMIO
> > intel_uncore_init // initializes MMIO
> > 
> > By initializing the function pointers first, we should be safe.
> > 
> > Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> 
> For the whole series:
> 
> Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>

All merged, thanks for patches&review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list