[Intel-gfx] [PATCH] drm/i915: Use unsigned long for obj->user_pin_count

Chris Wilson chris at chris-wilson.co.uk
Thu Oct 10 13:48:02 CEST 2013


On Thu, Oct 10, 2013 at 01:29:37PM +0200, Daniel Vetter wrote:
> At least on linux sizeof(long) == sizeof(void*) and the thinking
> is that you can grab about as many references as there's memory.
> 
> Doesn't really matter, just a bit of OCD since the fixed size data
> type in a pure in-kernel datastructure look off.
> 
> v2: Ville asked for an overflow check since no one prevents userspace
> from incrementing the pin count forever.

UINT_MAX? You just changed the type to unsigned long.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list