[Intel-gfx] [PATCH v3 3/4] drm/i915: remove device field from struct power_well

[Paulo Zanoni]

2013/10/27 Daniel Vetter <daniel at ffwll.ch>:
> On Fri, Oct 25, 2013 at 05:50:18PM -0200, Paulo Zanoni wrote:
>> 2013/10/25 Imre Deak <imre.deak at intel.com>:
>> > The only real need for this field was in
>> > i915_{request,release}_power_well, but there we can get at it by a
>> > container_of magic. Also since in the future we'll have multiple power
>> > wells each with its own power_well struct it makes sense to remove the
>> > field from there where it'd be just redundancy.
>> >
>> > Suggested-by: Paulo Zanoni <paulo.zanoni at intel.com>
>>
>> My original idea was to just move it from i915_power_well to
>> i915_power_domains, so hsw_pwr (which is the new external static
>> thing) would still have a pointer to our driver. This way we wouldn't
>> need the container_of magic. But your solution works too, and saves
>> 4/8 bytes :)
>>
>> Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
>
> First 3 patches merged, thanks.

I just realized that at some point we accidentally killed the
i915.disable_power_well option... I see the i915_disable_power_well
variable is not being used anywhere. Imre, can you please investigate
that?

Thanks,
Paulo


> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch



-- 
Paulo Zanoni