[Intel-gfx] commit 7195a50b5c7e00cc3312934fd022c3006b533d12 introduced a warning

Daniel Vetter daniel.vetter at ffwll.ch
Thu Oct 31 10:44:59 CET 2013


On Thu, Oct 31, 2013 at 10:15 AM, Ville Syrjälä
<ville.syrjala at linux.intel.com> wrote:
> On Thu, Oct 31, 2013 at 09:33:24AM +0800, feng xiangjun wrote:
>> Hello, ville.
>>
>> Latest git commit 7195a50b5c7e00cc3312934fd022c3006b533d12 introduced a warning,
>>
>> +
>> +static void intel_crt_get_config(struct intel_encoder *encoder,
>> +                                struct intel_crtc_config *pipe_config)
>> +{
>> +       struct drm_device *dev = encoder->base.dev;
>> +
>> +       pipe_config->adjusted_mode.flags |= intel_crt_get_flags(encoder);
>> +}
>> +
>>
>> dev not used.
>
> Daniel did the backport, so you get to blame him ;)
>
> I'm Cc:ing intel-gfx to avoid having the same discussion multiple
> times.

I'll call meh on this one, -next has a version of the patch that
doesn't have warnings.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list