[Intel-gfx] [PATCH] drm/i915: Fix cursor visibility checks also for the right/bottom screen edges

Daniel Vetter daniel at ffwll.ch
Tue Sep 3 15:31:03 CEST 2013


On Tue, Sep 3, 2013 at 10:13 AM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Tue, Sep 03, 2013 at 11:04:30AM +0300, ville.syrjala at linux.intel.com wrote:
>> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>>
>> First of all we should not be looking at fb->{width,height} as those do
>> not tell us what the actual pipe size is. Second of all we need to use
>> >= for the comparison.
>>
>> So fix the comparison, and make use of the new pipe_src_{w,h} to
>> determine the real pipe source dimensions.
>>
>> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Whoops.
>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
>
> And r-b for its sibling as well. I am pretty sure there are real-world
> bugs out there, but they are going to pretty be rare and the same user
> is never likely to see it twice... And just maybe more recent hw isn't
> quite so hang-happy!

Hm, can we have an igt for this? We kinda don't any sprite/cursor test
at all right now, but we need to start somewhere ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list