[Intel-gfx] [PATCH] drm/i915: Show WT caching in debugfs

Chris Wilson chris at chris-wilson.co.uk
Wed Sep 25 12:18:38 CEST 2013


On Wed, Sep 25, 2013 at 12:14:44PM +0200, Daniel Vetter wrote:
> On Wed, Sep 25, 2013 at 10:23:19AM +0100, Chris Wilson wrote:
> > Add the missing cache-level to the describe_obj() function for debug and
> > error reporting.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Merged to dinq ...
> 
> > ---
> >  drivers/gpu/drm/i915/i915_drv.h       | 2 +-
> >  drivers/gpu/drm/i915/i915_gpu_error.c | 1 +
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> > index 28c886d..e8ffd57 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -324,7 +324,7 @@ struct drm_i915_error_state {
> >  		u32 dirty:1;
> >  		u32 purgeable:1;
> >  		s32 ring:4;
> > -		u32 cache_level:2;
> > +		u32 cache_level:3;
> 
> ... but I wonder a bit whether we should just use the i915_cache_level
> enum here? Same for the ring id maybe. Otoh meh ;-)

Previous bytes semi-permanently allocated... A pittance compared to the
overallocated of a libva batchbuffer, but still...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list