[Intel-gfx] [PATCH 2/5] drm/i915: use wait_event_timeout when waiting for flip completions

Jesse Barnes jbarnes at virtuousgeek.org
Fri Sep 27 23:27:59 CEST 2013


On Fri, 27 Sep 2013 21:45:39 +0100
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> On Fri, Sep 27, 2013 at 12:57:23PM -0700, Jesse Barnes wrote:
> > We're shutting the crtc off and don't want to hang forever.
> 
> That scares me ever so slightly, especially ignoring the failure. Do you
> want to reset the display controller if the interrupts die, or just
> report a WARN, or propagate the failure back and make userspace try
> again?
> 
> But not taking any action at all is a recipe for a silent disaster. It
> has taken years to get to the point where we can turn off the pipes
> reliably...

Yeah this one is definitely a WIP.  I'd like to warn when this happens
and clean things up rather than just timing out and letting disaster
befall us later.

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list