[Intel-gfx] [PATCH 1/9] drm/i915: Set primary_disabled in intel_{enable, disable}_plane

Chris Wilson chris at chris-wilson.co.uk
Mon Sep 30 16:31:50 CEST 2013


On Mon, Sep 30, 2013 at 05:23:57PM +0300, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> If the primary gets marked as disabled while the pipe is off for
> instance, we should still re-enable it when the pipe is turned on,
> unless the sprite covers it fully also in that configuration.
> Unfortunately we do the plane visibility checks only in the sprite code,
> which is executed after the primary enabling when turning the pipe off.
> 
> Ideally we should compute the plane visibility before touching the
> hardware at all, but for now just set the primary_disabld flag
> in intel_{enable,disable}_plane.

Can I humbly request that we can these functions to
intel_enable_primary/intel_disable_primary?

In addition to setting the state, it would be nice to assert that the
state was still valid before the change.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list