[Intel-gfx] [RFC] tests/gem_bo_falloc: New igt for testing gem_fallocate() ioctl

Daniel Vetter daniel at ffwll.ch
Fri Apr 25 16:11:26 CEST 2014


On Fri, Apr 25, 2014 at 04:10:10PM +0200, Daniel Vetter wrote:
> On Fri, Apr 25, 2014 at 01:50:32PM +0100, arun.siluvery at linux.intel.com wrote:
> > +int main(int argc, char **argv)
> > +{
> > +	igt_subtest_init(argc, argv);
> > +
> > +	igt_fixture
> > +		fd = drm_open_any();
> > +
> > +	igt_subtest("gem_falloc arguments validation")
> > +		test_gem_falloc_arguments_validation(fd);
> 
> We tend to have no spaces in subtest names, please use dash '-' instead.
> space have a good chance to upset our tooling.

Also no need to repeat gem_falloc in each subtest, our tooling generates
an overall testcase name of "igt/$test_binary/$subtest_name". So adding
gem_falloc again is redundant.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list