[Intel-gfx] [PATCH] drm/i915: fix use after free during eDP encoder destroying

[Daniel Vetter]

On Fri, Dec 12, 2014 at 07:06:24PM +0200, Ville Syrjälä wrote:
> On Fri, Dec 12, 2014 at 05:57:38PM +0200, Imre Deak wrote:
> > After
> > 
> > commit a18c0af171bfb875012da26f23df051004726973
> > uthor: Thierry Reding <treding at nvidia.com>
> > Date:   Wed Dec 10 11:38:49 2014 +0100
> > 
> >     drm: Zero out DRM object memory upon cleanup

Please cc Thierry next time around. I've added him.

> > 
> > we will use the eDP encoder during destroying it. Fix this by calling
> > drm_encoder_cleanup() at a point when the encoder is not used any more.
> > This caused a NULL pointer dereference in pps_lock(), I can't see that
> > it caused any other problem.
> > 
> > All the other encoders seem to call drm_encoder_cleanup() at a safe
> > place.
> > 
> > Signed-off-by: Imre Deak <imre.deak at intel.com>
> 
> drm_encoder_cleanup() doesn't appear to have any nasty side effects
> so this looks sane.
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch