[Intel-gfx] [PATCH] drm/i915: Parsing logic for the Mipi sequence block

Daniel Vetter daniel at ffwll.ch
Tue Dec 16 01:46:26 PST 2014


On Tue, Dec 16, 2014 at 01:35:30PM +0530, Vandana Kannan wrote:
> From: vkorjani <vikas.korjani at intel.com>
> 
> New parsing logic for the mipi sequence block for GOP
> version 3 and above. The new version of the GOP includes
> the pmic, power on/off sequence which are newly adding
> to the existing sequences which are present.
> 
> Also, there are new fields which are added in
> the sequence to indicate the sequence size.
> 
> Signed-off-by: vkorjani <vikas.korjani at intel.com>
> Signed-off-by: Deepak M <m.deepak at intel.com>
> Signed-off-by: Rafael Barbalho <rafael.barbalho at intel.com>

This sob block is wrong since it doesn't have your name in it. And it has
a lot of other peoples name in it who might or might not have touched
this.

In general after piles of rebases and reworks it's usually better to claim
authorship of the thing, acknowledge the original author in the commit
message and put everyone with a sob into the Cc: list.

Sobs really should document how was passed around, not how it was
developed. So internally that pile of sobs makes sense (to chase patches
through internal trees) but for upstream submission we can trim them a
lot.

Note this isn't about your patch here really, I've seen this happen more
and more for some vpg submissions and it's getting a bit excessive.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the Intel-gfx mailing list