[Intel-gfx] [PATCH igt 22/28] kms_pipe_crc_basic: Use kmstest_create_color_fb()

Damien Lespiau damien.lespiau at intel.com
Fri Feb 7 15:49:06 CET 2014


Reducing again the per-test number of lines.

Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
---
 tests/kms_pipe_crc_basic.c | 26 ++++++--------------------
 1 file changed, 6 insertions(+), 20 deletions(-)

diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
index f4de64f..8a45c5b 100644
--- a/tests/kms_pipe_crc_basic.c
+++ b/tests/kms_pipe_crc_basic.c
@@ -55,25 +55,6 @@ static void test_bad_command(data_t *data, const char *cmd)
 	fclose(ctl);
 }
 
-static void create_fb_for_mode(data_t *data, drmModeModeInfo *mode)
-{
-	unsigned int fb_id;
-	cairo_t *cr;
-
-	fb_id = kmstest_create_fb(data->drm_fd,
-				  mode->hdisplay, mode->vdisplay,
-				  32 /* bpp */, 24 /* depth */,
-				  false /* tiling */,
-				  &data->fb);
-	igt_assert(fb_id);
-
-	cr = kmstest_get_cairo_ctx(data->drm_fd, &data->fb);
-	kmstest_paint_color(cr, 0, 0, mode->hdisplay, mode->vdisplay,
-			    0.0, 1.0, 0.0);
-	igt_assert(cairo_status(cr) == 0);
-	cairo_destroy(cr);
-}
-
 #define TEST_SEQUENCE (1<<0)
 
 static void test_read_crc(data_t *data, int pipe, unsigned flags)
@@ -95,7 +76,12 @@ static void test_read_crc(data_t *data, int pipe, unsigned flags)
 			pipe_name(pipe));
 
 		mode = igt_output_get_mode(output);
-		create_fb_for_mode(data, mode);
+		kmstest_create_color_fb(data->drm_fd,
+					mode->hdisplay, mode->vdisplay,
+					DRM_FORMAT_XRGB8888,
+					false, /* tiled */
+					0.0, 1.0, 0.0,
+					&data->fb);
 
 		primary = igt_ouput_get_plane(output, 0);
 		igt_plane_set_fb(primary, &data->fb);
-- 
1.8.3.1




More information about the Intel-gfx mailing list