[Intel-gfx] [PATCH v2 3/3] drm/i915: Prevent MI_DISPLAY_FLIP straddling two cachelines on IVB

Chris Wilson chris at chris-wilson.co.uk
Tue Feb 11 15:14:28 CET 2014


On Tue, Feb 11, 2014 at 03:55:50PM +0200, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> According to BSpec the entire MI_DISPLAY_FLIP packet must be contained
> in a single cacheline. Make sure that happens.
> 
> v2: Use intel_ring_begin_cacheline_safe()

Ugh, no. Let's not make intel_ring_begin() any more complicated and just
introduce a function to align the current head in the ringbuffer to a
cacheline. Especially with such an interface that is hard to get right.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list