[Intel-gfx] [PATCH 1/3] drm/i915: Use a pipe variable to cycle trough the pipes

Chris Wilson chris at chris-wilson.co.uk
Fri Feb 28 18:25:54 CET 2014


On Fri, Feb 28, 2014 at 04:42:13PM +0000, Damien Lespiau wrote:
> I recently fumbled a patch because I wrote twice num_sprites[i], and it
> was the right thing to do in only 50% of the cases.
> 
> This patch ensures I need to write num_sprites[pipe], ie it should be
> self-documented that it's per-pipe number of sprites without having to
> look at what is 'i' this time around.
> 
> It's all a lame excuse, but it does make it harder to redo the same
> mistake.
> 
> Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>

I'd review patches to change all for_each_pipe(i) to
for_each_pipe(pipe).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list