[Intel-gfx] [PATCH V4] drm/i915: VLV2 - Fix hotplug detect bits

Daniel Vetter daniel at ffwll.ch
Thu Jan 23 11:52:51 CET 2014


On Thu, Jan 23, 2014 at 11:50:38AM +0100, Daniel Vetter wrote:
> On Thu, Jan 23, 2014 at 12:13:41AM -0700, Todd Previte wrote:
> > Add new definitions for hotplug live status bits for VLV2 since they're
> > in reverse order from the gen4x ones.
> > 
> > Changelog:
> > - Restored gen4 bit definitions
> > - Added new definitions for VLV2
> > - Added platform check for IS_VALLEYVIEW() in dp_detect to use the correct
> >   bit defintions
> > - Replaced a lost trailing brace for the added switch()
> > 
> > Signed-off-by: Todd Previte <tprevite at gmail.com>
> 
> I've bikeshedded your patch a bit for more consistency. Wrt the patch
> changelog please don't smash it all into one but keep a separate changelog
> per revision. Otherwise it's not clear what e.g. changed from v3->v4 and
> so no too useful for reviewers when rechecking patches.

Also please add bugzilla links and cc: stable for bugfixes like these into
the sob section of the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list