[Intel-gfx] [PATCH v2 1/2] drm/i915: fix possible refcount leak when resetting forcewake

Daniel Vetter daniel at ffwll.ch
Fri Jun 6 22:54:57 CEST 2014


On Fri, Jun 6, 2014 at 10:44 PM, Imre Deak <imre.deak at intel.com> wrote:
> Let's say that forcewake timer is pending, holding the runtime pm ref.
> System suspend is called - it's not prevented by either this ref or the
> above autosuspend delay - in the suspend handler we eventually call
> force_wake_reset which cancels the timer, leaking the runtime pm ref.

Hm, I indeed mixed things up. I guess the window is small with the
short timeout we have for the forcewake timer, but still the first
patch makes sense for -fixes. Jani?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list