[Intel-gfx] [PATCH] drm/i915: Attach a PSR property on eDP

Damien Lespiau damien.lespiau at intel.com
Sat Jun 14 10:48:46 CEST 2014


On Sat, Jun 14, 2014 at 09:26:20AM +0100, Chris Wilson wrote:
> On Sat, Jun 14, 2014 at 09:17:34AM +0100, Damien Lespiau wrote:
> > On Fri, Jun 13, 2014 at 09:32:47PM +0100, Chris Wilson wrote:
> > > Let userspace know the status of Panel Self-Refresh by virtue of a
> > > property on the appropriate connector.
> > > 
> > > v2: Only attach the property if the driver is capable of PSR.
> > > 
> > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > 
> > Can we have an updated property table in Documentation/DocBook/drm.tmpl
> > as well?
> 
> If you care to give me a taylor made example... ;-)

That prompted me wondering if it should be a DRM property instead, but there's
no harm in keeping it i915 specific until there's a second user.

$ git diff
diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
index 7df3134..3bb7ecb 100644
--- a/Documentation/DocBook/drm.tmpl
+++ b/Documentation/DocBook/drm.tmpl
@@ -2648,7 +2648,7 @@ void intel_crt_init(struct drm_device *dev)
	<td valign="top" >TBD</td>
	</tr>
	<tr>
-	<td rowspan="21" valign="top" >i915</td>
+	<td rowspan="22" valign="top" >i915</td>
	<td rowspan="3" valign="top" >Generic</td>
	<td valign="top" >"Broadcast RGB"</td>
	<td valign="top" >ENUM</td>
@@ -2799,6 +2799,14 @@ void intel_crt_init(struct drm_device *dev)
	<td valign="top" >TBD</td>
	</tr>
	<tr>
+	<td valign="top" >eDP</td>
+	<td valign="top" >"PSR"</td>
+	<td valign="top" >ENUM | IMMUTABLE</td>
+	<td valign="top" >{ "Idle", "Active" }</td>
+	<td valign="top" >Connector</td>
+	<td valign="top" >Whether PSR is currently active or not</td>
+	</tr>
+	<tr>
	<td rowspan="3" valign="top" >CDV gma-500</td>
	<td rowspan="3" valign="top" >Generic</td>
	<td valign="top" >"Broadcast RGB"</td>

(It even renders correctly!)

-- 
Damien



More information about the Intel-gfx mailing list