[Intel-gfx] [PATCH v3] drm/i915: Force GPU Freq to lowest while suspending.

[Daniel Vetter]

On Fri, Jun 20, 2014 at 1:59 PM,  <deepak.s at linux.intel.com> wrote:
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 2043c4b..6bbb90b 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4881,6 +4881,9 @@ void intel_suspend_gt_powersave(struct drm_device *dev)
>         /* Interrupts should be disabled already to avoid re-arming. */
>         WARN_ON(dev->irq_enabled);
>
> +       /* Force GPU to min freq during suspend */
> +       gen6_rps_idle(dev_priv);
> +

Shouldn't this be _after_ we've cancelled the rps works? Otherwise the
work item might sneak in and undo the idling between the idle and work
cancelling.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch