[Intel-gfx] [PATCH] drm/i915: Track frontbuffer invalidation/flushing

Chris Wilson chris at chris-wilson.co.uk
Thu Jun 19 17:12:08 CEST 2014


On Thu, Jun 19, 2014 at 04:01:59PM +0200, Daniel Vetter wrote:
> diff --git a/drivers/gpu/drm/i915/intel_overlay.c b/drivers/gpu/drm/i915/intel_overlay.c
> index 99b6c142a095..1c002196ed47 100644
> --- a/drivers/gpu/drm/i915/intel_overlay.c
> +++ b/drivers/gpu/drm/i915/intel_overlay.c
> @@ -787,6 +787,9 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay,
>  	overlay->old_vid_bo = overlay->vid_bo;
>  	overlay->vid_bo = new_bo;
>  
> +	intel_frontbuffer_flush(dev,
> +				INTEL_FRONTBUFFER_OVERLAY(pipe));
> +

If we want to be strict, we could do the flip_prepare, flip_complete
here as well. Basically, I'm arguing that this is actually a
semi-disguised flip.

With this changed to _flip,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list