[Intel-gfx] [PATCH 09/10] i915: add DP 1.2 MST support (v0.3)

Dave Airlie airlied at gmail.com
Wed May 14 02:03:53 CEST 2014


>
> So we leak all dynamically created objects? There's no
> kfree(intel_connector) here and we cannot add it because
> drm_mode_object_find() is not ref-counted. So we keep the connector in
> the mode_group and wait until the final drm_mode_config_cleanup()? But
> drm_connector_cleanup() already removes the connector from the
> mode-group, so we eventually leak the object.
>

Seems like freeing it should be fine, it was just an oversight,

Since any objects you get with find are only valid under mode_config.mutex,
yes some drivers mess this up, but they should be fixed.

Dave.



More information about the Intel-gfx mailing list