[Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode

Daniel Vetter daniel at ffwll.ch
Mon Nov 3 12:39:33 CET 2014


On Thu, Oct 30, 2014 at 11:38:20AM -0700, Jesse Barnes wrote:
> On Wed, 29 Oct 2014 16:30:43 +0200
> Ander Conselvan de Oliveira <conselvan2 at gmail.com> wrote:
> > On 10/23/2014 09:50 PM, Jesse Barnes wrote:
> > > +static int intel_modeset_compute_config(struct drm_crtc *crtc,
> > 
> > s/drm_crtc/intel_crtc/
> 
> Since 2/3 of the functions this one calls take a drm_crtc I figured I'd
> leave it for a big cleanup patch (maybe cocci could do it).

Imo if it's driver-internal just do it, otherwise there will always be
hold-outs. And the &crtc->base doesn't really look all that ugly imo.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list