[Intel-gfx] [PATCH] drm/i915: Mark fastboot as unsafe

Daniel Vetter daniel.vetter at ffwll.ch
Tue Nov 4 15:29:57 CET 2014


Fastboot in its current incarnation assumes that the pfit isn't
relevatn for the state and that it can be disabled without restarting
the crtc. Unfortunately that's not the case on gen2/3 - it upsets the
hw and results in a black screen.

Worse, the way the current fastboot hack is structure we can't detect
and work around this in the code, since the fastboot smashes the
adjusted mode into crtc->mode. Which means the higher levels can't
correctly figure out that this is a lie and act accordingly.

Since fastboot is just a tech demo let's mark the module option as
experimental and close the coresponding reports as wontfix.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84682
Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
---
 drivers/gpu/drm/i915/i915_params.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index c91cb2033cc5..93d792349668 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -138,7 +138,7 @@ MODULE_PARM_DESC(disable_power_well,
 module_param_named(enable_ips, i915.enable_ips, int, 0600);
 MODULE_PARM_DESC(enable_ips, "Enable IPS (default: true)");
 
-module_param_named(fastboot, i915.fastboot, bool, 0600);
+module_param_named_unsafe(fastboot, i915.fastboot, bool, 0600);
 MODULE_PARM_DESC(fastboot,
 	"Try to skip unnecessary mode sets at boot time (default: false)");
 
-- 
2.1.1




More information about the Intel-gfx mailing list