[Intel-gfx] [PATCH 2/2] drm/i915: Capture module params on hang

[Daniel Vetter]

On Thu, Nov 06, 2014 at 11:13:33AM +0000, Chris Wilson wrote:
> On Thu, Nov 06, 2014 at 01:03:47PM +0200, Mika Kuoppala wrote:
> > @@ -1303,7 +1332,10 @@ void i915_capture_error_state(struct drm_device *dev, bool wedged,
> >  	error->display = intel_display_capture_error_state(dev);
> >  
> >  	i915_error_capture_msg(dev, error, wedged, error_msg);
> > +	i915_error_capture_module_params(error);
> > +
> >  	DRM_INFO("%s\n", error->error_msg);
> > +	DRM_INFO("%s\n", error->module_params_msg);
> 
> Just add it to the error state, not the dmesg every single time.

Yeah I think this might be better in the error state. It's not that
important to triage most bugs at least I think, and we already print a lot
of stuff into dmesg that everyone seems to ignore ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch