[Intel-gfx] [PATCH v2 6/8] drm/i915: sanitize rps irq enabling

Chris Wilson chris at chris-wilson.co.uk
Mon Nov 10 14:45:32 CET 2014


On Mon, Nov 10, 2014 at 03:41:05PM +0200, Imre Deak wrote:
> Atm we first enable the RPS interrupts then we clear any pending ones.
> By this we could lose an interrupt arriving after we unmasked it. This
> may not be a problem as the caller should handle such a race, but logic
> still calls for the opposite order. Also we can delay enabling the
> interrupts until after all the RPS initialization is ready with the
> following order:
> 

0. disable left-over RPS
> 1. clear any pending RPS interrupts
> 2. initialize RPS
> 3. enable RPS interrupts
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list