[Intel-gfx] [PATCH v2] drm/i915: Add the predicate source registers to the register whitelist

Daniel Vetter daniel at ffwll.ch
Tue Nov 11 16:26:50 CET 2014


On Fri, Nov 07, 2014 at 07:00:26PM +0000, Neil Roberts wrote:
> The predicate source registers are needed to implement conditional
> rendering without stalling. The two source registers are used to load
> the previous values of the PS_DEPTH_COUNT register saved from
> PIPE_CONTROL commands. These can then be compared and used to set the
> predicate enable bit via the MI_PREDICATE command.
> 
> The command parser version number is increased to 2 to make it easier
> to detect the new functionality in user space.
> 
> Signed-off-by: Neil Roberts <neil at linux.intel.com>
> ---
> 
> Here is a v2 of the patch that also updates the command parser version
> to make it easier to detect whether we can use the register in Mesa.
> I have posted a second version of the Mesa patch which uses this here:
> 
> http://lists.freedesktop.org/archives/mesa-dev/2014-November/070362.html
> 
> This was suggested by Glenn Kennard.

Ok, I've merged this one, since that means you at least won't get an
-EINVAL. But you can't yet enable the feature in mesa since it's still
no-opped out. Let's hope that v3 actually starts granting rights (but
please don't encode that in any merge mesa patch before it's official in
the kernel, Dave Airlie _will_ revert it even if it breaks the build) and
that this happens soon.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list