[Intel-gfx] [PATCH v3] drm/i915: Initialize workarounds in logical ring mode too

[Daniel Vetter]

On Tue, Nov 11, 2014 at 06:10:50PM +0200, Mika Kuoppala wrote:
> Michel Thierry <michel.thierry at intel.com> writes:
> > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h
> > index f0e7761..a6c4458 100644
> > --- a/drivers/gpu/drm/i915/intel_ringbuffer.h
> > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
> > @@ -149,6 +149,8 @@ struct  intel_engine_cs {
> >  	int		(*init)(struct intel_engine_cs *ring);
> >  
> >  	int		(*init_context)(struct intel_engine_cs *ring);
> > +	int		(*init_context_lrc)(struct intel_engine_cs *ring,
> > +				      struct intel_context *ctx);
> 
> I was going to advertise earlier that using this abstraction will
> make your patch smaller.
> 
> You don't need to introduce new interface here. Just
> add struct intel_context *ctx as a parameter to (*init_context).

Yeah, same here - sorry for being unclear in my review comment.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch