[Intel-gfx] [PATCH 2/2] drm/i915: Drop WaRsForcewakeWaitTC0:vlv

Daniel Vetter daniel at ffwll.ch
Mon Nov 17 19:11:41 CET 2014


On Tue, Nov 18, 2014 at 02:10:35PM +0530, Deepak S wrote:
> 
> On Friday 14 November 2014 01:42 AM, ville.syrjala at linux.intel.com wrote:
> >From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> >
> >GEN6_GT_THREAD_STATUS_REG doesn't seem to exist on VLV. Reads just give
> >0x0 no matter what the state of the render and media wells.
> >
> >There was also some hint in the Gunit HAS that thread status not being
> >needed on VLV, and hence dropped when bringing stuff over from the IVB
> >design. Not really a definite comment about the specific register itself
> >though.
> >
> >Also the w/a itself is no longer listed for VLV in the database. It was
> >there some time ago in the past, but I guess someone figured out the
> >mistake and dropped it.
> >
> >So let's just drop it from the code as well.
> >
> >Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> >---
> >  drivers/gpu/drm/i915/intel_uncore.c | 4 ----
> >  1 file changed, 4 deletions(-)
> >
> >diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> >index f318c03..3aa5c65 100644
> >--- a/drivers/gpu/drm/i915/intel_uncore.c
> >+++ b/drivers/gpu/drm/i915/intel_uncore.c
> >@@ -223,10 +223,6 @@ static void __vlv_force_wake_get(struct drm_i915_private *dev_priv,
> >  					FORCEWAKE_ACK_TIMEOUT_MS))
> >  			DRM_ERROR("Timed out: waiting for media to ack.\n");
> >  	}
> >-
> >-	/* WaRsForcewakeWaitTC0:vlv */
> >-	if (!IS_CHERRYVIEW(dev_priv->dev))
> >-		__gen6_gt_wait_for_thread_c0(dev_priv);
> >  }
> >  static void __vlv_force_wake_put(struct drm_i915_private *dev_priv,
> 
> I did not find WA in DB.
> S0 :) - Reviewed-by: Deepak S<deepak.s at linux.intel.com>

Both merged, thanks for patches&review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list