[Intel-gfx] [PATCH] drm/i915: Propagate invalid setcrtc cloning errors back to userspace

[Matt Roper]

On Mon, Nov 17, 2014 at 08:06:47PM +0100, Daniel Vetter wrote:
> On Mon, Nov 17, 2014 at 09:59:28AM -0800, Matt Roper wrote:
> > When invalid cloning configurations were detected during modeset, we
> > never copied the error code into the return value variable, leading us
> > to return 0 (success) to userspace.
> > 
> > Testcase: igt/kms_setmode
> > Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
> 
> I guess this is a regression from 
> 
> commit 50f5275698df4490046cc5b4ed2018abb642a803
> Author: Jesse Barnes <jbarnes at virtuousgeek.org>
> Date:   Fri Nov 7 13:11:00 2014 -0800
> 
>     drm/i915: use compute_config in set_config v4
> 
> Is this the one we have a bugzilla for already? Jesse?
> -Daniel

Looks like it might be this one:

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86226


Matt

> 
> > ---
> >  drivers/gpu/drm/i915/intel_display.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index dda97b3..cf57b74 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -11477,6 +11477,7 @@ static int intel_crtc_set_config(struct drm_mode_set *set)
> >  						   &prepare_pipes,
> >  						   &disable_pipes);
> >  	if (IS_ERR(pipe_config)) {
> > +		ret = PTR_ERR(pipe_config);
> >  		goto fail;
> >  	} else if (pipe_config) {
> >  		if (to_intel_crtc(set->crtc)->new_config->has_audio !=
> > -- 
> > 1.8.5.1
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch

-- 
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795