[Intel-gfx] [PATCH 1/2] drm/i915/ddi: set has_infoframe flag on DDI too

Daniel Vetter daniel at ffwll.ch
Tue Nov 18 09:14:05 CET 2014


On Mon, Nov 17, 2014 at 01:08:46PM -0800, Jesse Barnes wrote:
> Just like we do in the HDMI code, set the infoframe flag if we detect an
> HDMI sink.
> 
> Reported-by: Paulo Zanoni <przanoni at gmail.com>
> Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 86745da..78576e0 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2062,6 +2062,7 @@ void intel_ddi_get_config(struct intel_encoder *encoder,
>  	switch (temp & TRANS_DDI_MODE_SELECT_MASK) {
>  	case TRANS_DDI_MODE_SELECT_HDMI:
>  		pipe_config->has_hdmi_sink = true;
> +		pipe_config->has_infoframe = true;

Infoframes aren't controlled by this bit here but set in
HSW_TVIDEO_DIP_CTL. Since the point of this is to detect mismatches
between the bios and what we'd like to have for fastboot I think we need
to check that register. Instead of blindly deriving state to appease the
cross checker.
-Daniel

>  	case TRANS_DDI_MODE_SELECT_DVI:
>  	case TRANS_DDI_MODE_SELECT_FDI:
>  		break;
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list