[Intel-gfx] [PATCH 1/5] drm/i915: s/init()/init_hw()/ in intel_engine_cs

Chris Wilson chris at chris-wilson.co.uk
Thu Nov 20 09:03:29 CET 2014


On Thu, Nov 20, 2014 at 12:33:04AM +0100, Daniel Vetter wrote:
> This is (mostly, some exceptions that need fixing) the hw setup
> function which starts the ring. And not the function which allocates
> all the resources.
> 
> Make this clear by giving it a better name.

->resume() because it should be only called in the resume paths after
init! And we should have a ->susped() as well.

(Not keen on the init_hw we have spread out.)

See

http://cgit.freedesktop.org/~ickle/linux-2.6/tree/drivers/gpu/drm/i915/i915_gem.c#n4464
http://cgit.freedesktop.org/~ickle/linux-2.6/tree/drivers/gpu/drm/i915/i915_gem.c#n4394
http://cgit.freedesktop.org/~ickle/linux-2.6/tree/drivers/gpu/drm/i915/i915_gem.c#n4572

for the distinction
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list