[Intel-gfx] [PATCH] drm/i915: Move init_unused_rings to gem_init_hw

Dave Gordon david.s.gordon at intel.com
Fri Nov 21 20:01:54 CET 2014


On 20/11/14 08:45, Daniel Vetter wrote:
> We need to do that every time we resume the rings, not just at load.
> I've overlooked this in my untangling of the ring init code.

Hi Daniel,

another thing that needs untangling in the general maze of init code is
the initialisation of the active and request lists -- Thomas Daniel's
complaint about 11/28 of the s/seqno/request/ patchset was essentially
because John was adding more lists that appear to be redundantly
initialised in multiple places. Please see my followup at
http://lists.freedesktop.org/archives/intel-gfx/2014-November/055856.html

As it looks like you're getting rid of intel_render_ring_init_dri(), if
we could also resolve whether init_ring_lists() is also now redundant,
that would mean there were no duplicated list initialisations :)

Thanks,
.Dave.



More information about the Intel-gfx mailing list