[Intel-gfx] [PATCH] drm/i915: Handle runtime pm in the CRC setup code

Daniel Vetter daniel at ffwll.ch
Tue Nov 25 13:58:34 CET 2014


On Tue, Nov 25, 2014 at 12:12:35PM +0000, Damien Lespiau wrote:
> On Mon, Nov 24, 2014 at 09:43:12PM +0100, Daniel Vetter wrote:
> > Note that we need the rpm_get/put to make power_is_enabled work
> > properly.
> 
> I still don't get that. intel_display_power_is_enabled() only checks for
> states kept in dev_priv. In particular, it doesn't touch the hardware
> and it looks at dev_priv->pm.suspended. So it seems we should be
> covered?

Hm, mixup on my side - we indeed don't check the hw state. Somehow the
check_power_well_state thing confused me. I'll rip the get/put out.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list