[Intel-gfx] [PATCH] drm/i915: Check locking in i915_gem_request_unreference

John Harrison John.C.Harrison at Intel.com
Wed Nov 26 13:41:43 CET 2014


On 26/11/2014 10:39, Chris Wilson wrote:
> On Wed, Nov 26, 2014 at 10:28:13AM +0100, Daniel Vetter wrote:
>> With refcounting it looks like you can just drop that refcount, but
>> that's not really the case. So make sure no one forgets.
>>
>> Motivated by the unlocked call in the mmio flip code.
> I had an unlocked variant for exactly this purpose (and a few others
> where we do not want to take the lock again) and so also had the WARN
> inside i915_request_free.
>
> Drop the _gem_, the requests are lower level than GEM itself.
> -Chris
>

Daniel: Should I fold the WARN_ON patch into my patch series and repost?

Chris: Are you saying that you want an extra patch to rename 
'drm_i915_gem_request' to 'drm_i915_request' throughout the entire driver?




More information about the Intel-gfx mailing list