[Intel-gfx] [PATCH 02/16] drm/i915: remove dead code from legacy suspend handler

Daniel Vetter daniel at ffwll.ch
Tue Oct 21 14:11:59 CEST 2014


On Tue, Oct 21, 2014 at 02:56:46PM +0300, Ville Syrjälä wrote:
> On Wed, Sep 10, 2014 at 06:16:55PM +0300, Imre Deak wrote:
> > The legacy DRM suspend logic (effective in UMS) doesn't handle any S4 thaw
> > events so we don't need to care about it either. Only S3 suspend and S4
> > freeze events are handled. Leave an assert behind to be sure.
> > 
> > Signed-off-by: Imre Deak <imre.deak at intel.com>
> 
> Looks correct.
> 
> Although it the lack of .thaw() means there's no error recovery when
> things go south. But this is UMS so who cares.
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list