[Intel-gfx] [PATCH 05/89] drm/i915/skl: i915_swizzle_info gen9 fix

Damien Lespiau damien.lespiau at intel.com
Thu Sep 4 17:26:00 CEST 2014


On Thu, Sep 04, 2014 at 03:14:45PM +0200, Daniel Vetter wrote:
> On Thu, Sep 04, 2014 at 12:26:31PM +0100, Damien Lespiau wrote:
> > From: Robert Beckett <robert.beckett at intel.com>
> > 
> > Fix ARB_MODE register read for gen >= 8 in i915_swizzle_info
> > 
> > Signed-off-by: Robert Beckett <robert.beckett at intel.com>
> > Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
> 
> given that the swizzle stuff is gone, shouldn't we just have a gen9+
> check to do nothing?

Well, the swizzled bits are still in the SKL docs, they are really not
expected to be used though. We can either still dump them in that
debugfs file, or nothing at all. I vote for keeping the dump "just in
case", but I can see the alternative working as well. No strong opinion
either way.

-- 
Damien



More information about the Intel-gfx mailing list