[Intel-gfx] [PATCH] drm/i915: Add secure batch ggtt vma as active during execution

Chris Wilson chris at chris-wilson.co.uk
Thu Sep 11 22:31:13 CEST 2014


On Thu, Sep 11, 2014 at 09:30:27AM -0700, Volkin, Bradley D wrote:
> On Thu, Sep 11, 2014 at 01:49:07AM -0700, Chris Wilson wrote:
> > vma->exec_entry = memset(&dummy_exec_entry, 0, sizeof(dummy_exec_entry);
> > 
> > Then you can kill the additional if (entry) checks.
> 
> Also, don't we need to set vma->exec_entry->flags = __EXEC_OBJECT_HAS_PIN ?

Yes we do. I realised that and mentioned it to Mika on IRC right after
sending :|

All the more reason for using the dummy_exec_entry/shadow_exec_entry.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list