[Intel-gfx] [PATCH 2/3] drm/i915: eDP Panel Power sequencing PP_DIV register changes

David Weinehall david.weinehall at linux.intel.com
Thu Apr 30 02:27:08 PDT 2015


On Thu, Apr 30, 2015 at 01:07:34PM +0530, Vandana Kannan wrote:
> BXT does not have PP_DIV register. Making changes to handle this.

[snip]

> +		if (!IS_BROXTON(dev))
> +			dev_priv->regfile.savePP_DIVISOR =
> +				I915_READ(PCH_PP_DIVISOR);

In case some future products also lack this register this will quickly
end up messy.  Maybe it'd be better to add a HAS_PP_DIVISOR(dev) macro
or something like that?


Kind regards, David Weinehall


More information about the Intel-gfx mailing list