[Intel-gfx] [PATCH] drm/i915: Tone done *ERROR* for an expected VBT condition

Chris Wilson chris at chris-wilson.co.uk
Wed Aug 5 01:48:20 PDT 2015


On Wed, Aug 05, 2015 at 10:34:07AM +0200, Daniel Vetter wrote:
> On Fri, Jul 31, 2015 at 11:15:27AM +0100, Chris Wilson wrote:
> > Older VBT (e.g. gen2) have smaller child block defintions, so do not cry
> > wolf over an error that is outside of our control and is not an error
> > anyway.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > ---
> >  drivers/gpu/drm/i915/intel_bios.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> > index 2ff9eb00fdec..f8afbafa8e02 100644
> > --- a/drivers/gpu/drm/i915/intel_bios.c
> > +++ b/drivers/gpu/drm/i915/intel_bios.c
> > @@ -1023,7 +1023,7 @@ parse_device_mapping(struct drm_i915_private *dev_priv,
> >  		return;
> >  	}
> >  	if (p_defs->child_dev_size < sizeof(*p_child)) {
> 
> This line was added in
> 
> commit 90e4f1592bb6e82f6690f0e05a8aadcf04d7bce7
> Author: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Date:   Wed Mar 25 18:45:58 2015 +0200
> 
>     drm/i915: Fix the VBT child device parsing for BSW
> 
> Since vbt is complete pain I started requiring that we match expected
> sizes with vbt versions. Can some one please fix this?

I hope id:20150804135552.GC6150 at boom does.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list