[Intel-gfx] [PATCH 0/3] HDMI optimization series

David Weinehall david.weinehall at linux.intel.com
Wed Aug 12 04:55:55 PDT 2015


On Tue, Aug 11, 2015 at 11:41:42AM +0200, Daniel Vetter wrote:
> On Mon, Aug 10, 2015 at 02:05:47PM +0530, Jindal, Sonika wrote:
> > 
> > 
> > On 8/10/2015 1:38 PM, Daniel Vetter wrote:
> > >On Mon, Aug 10, 2015 at 04:50:37AM +0000, Jindal, Sonika wrote:
> > >>Hi Daniel,
> > >>
> > >>That patch was already merged:
> > >>http://lists.freedesktop.org/archives/intel-gfx/2015-July/071142.html
> > >>
> > >>For SKL, the above patch helped in getting the correct ISR bits set.
> > >>One option is to enable the HDMI optimization from VLV onwards.
> > >>I don't have an ivb machine to try out the issue.
> > >
> > >ivb is simple the machine I have here, but when we tried this the last
> > >time around we had reports for all platforms (your patch still doesn't
> > >cite the relevant sha1 btw). I think there are 3 possible explanations:
> > >
> > Yes, I don't know which were those patches and how to find them..
> 
> git blame (recursively) and git log on intel_hdmi.c will tell you the
> story. I require all these extensive git commit messages because I dig
> them out daily. Also git log --pickaxe (well I use the equivalent in the
> gitk gui). If these tools are generally unknown in the vpg display team
> then we absolutely need to do a training session about them, they're
> extremely powerful and useful to dig out the history of the i915 code.

git blame I use a lot to find whom to ask for clarification.
pickaxe, however, was new to me. Thanks for the tip, will look into it.

As far as training sessions about git goes, I think a lot of people could
benefit from it; git has a LOT of hidden gems, and it seems almost
everyone has different workflows.


Kind regards, David


More information about the Intel-gfx mailing list