[Intel-gfx] ✗ failure: UK.CI.checkpatch.pl

Patchwork patchwork at annarchy.freedesktop.org
Thu Dec 17 06:50:42 PST 2015


== Summary ==

  • Testing drm/i915: edp resume/On time optimization.

WARNING: Duplicate signature
#17: 
Signed-off-by: Abhay Kumar <abhay.kumar at intel.com>

WARNING: line over 100 characters
#60: FILE: drivers/gpu/drm/i915/intel_dp.c:2055:
+	panel_power_off_duration  = (intel_dp->panel_power_on_timestamp.tv_sec-intel_dp->panel_power_off_timestamp.tv_sec) * 1000000 +  intel_dp->panel_power_on_timestamp.tv_usec-intel_dp->panel_power_off_timestamp.tv_usec;

WARNING: space prohibited before semicolon
#61: FILE: drivers/gpu/drm/i915/intel_dp.c:2056:
+	panel_power_off_duration = panel_power_off_duration / 1000 ;

ERROR: space required before the open parenthesis '('
#64: FILE: drivers/gpu/drm/i915/intel_dp.c:2059:
+	if(panel_power_off_duration >= intel_dp->panel_power_cycle_delay) {

WARNING: braces {} are not necessary for any arm of this statement
#64: FILE: drivers/gpu/drm/i915/intel_dp.c:2059:
+	if(panel_power_off_duration >= intel_dp->panel_power_cycle_delay) {
[...]
+	} else {
[...]

WARNING: line over 100 characters
#67: FILE: drivers/gpu/drm/i915/intel_dp.c:2062:
+		intel_dp->panel_power_cycle_delay = intel_dp->panel_power_cycle_delay - panel_power_off_duration;


Your patch has style problems, please review.

NOTE: Ignored message types: BLOCK_COMMENT_STYLE COMMIT_LOG_LONG_LINE COMPLEX_MACRO FILE_PATH_CHANGES GIT_COMMIT_ID SPLIT_STRING

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




More information about the Intel-gfx mailing list