[Intel-gfx] [PATCH] drm/i915: Remove bogus locking check in the hangcheck code

Chris Wilson chris at chris-wilson.co.uk
Tue Feb 3 03:00:56 PST 2015


On Tue, Feb 03, 2015 at 11:49:00AM +0100, Daniel Vetter wrote:
> You can _never_ assert that a lock is not held, except in some very
> restricted corner cases where it's guranteed that your code is running
> single-threade (e.g. driver load before you've published any pointers
> leading to that lock).

Except that the mistake here was that we thought we were already inside
the strictly single threaded recovery phase. Seems a bit blasé not to
mention that recovery includes several tricks to break locks.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list