[Intel-gfx] [PATCH] drm/i915: Don't bail out early on i915_handle_error

Chris Wilson chris at chris-wilson.co.uk
Tue Feb 3 04:29:19 PST 2015


On Tue, Feb 03, 2015 at 02:27:25PM +0200, Mika Kuoppala wrote:
> If we bail out from handling the error, we never wake up
> the waiters, resulting in a stuck processes.
> 
> This regression was introduced in:
> 
> commit b8d24a06568368076ebd5a858a011699a97bfa42
> Author: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> Date:   Wed Jan 28 17:03:14 2015 +0200
> 
>     drm/i915: Remove nested work in gpu error handling
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=88933
> Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>

I was hoping you would also try to think of another way to detect the
race you postulated... :)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list