[Intel-gfx] [PATCH] drm/i915/fbc: fix the check for already reserved fbc size

[Daniel Vetter]

On Thu, Feb 05, 2015 at 10:06:05AM +0000, Chris Wilson wrote:
> On Thu, Feb 05, 2015 at 12:04:27PM +0200, Jani Nikula wrote:
> > The check for previously reserved stolen space size for FBC in
> > i915_gem_stolen_setup_compression() did not take the compression
> > threshold into account. Fix this by storing and comparing to
> > uncompressed size instead.
> > 
> > The bug has been introduced in
> > 
> > commit 5e59f7175f96550ede91f58d267d2b551cb6fbba
> > Author: Ben Widawsky <benjamin.widawsky at intel.com>
> > Date:   Mon Jun 30 10:41:24 2014 -0700
> > 
> >     drm/i915: Try harder to get FBC
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88975
> > Suggested-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Ben Widawsky <benjamin.widawsky at intel.com>
> > Cc: stable at vger.kernel.org # 3.17+

Dropped since fbc isn't enabled by default.

> > Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> 
> Thanks, I think uncompressed_size clarifies exactly what we want to
> compare against (is this allocation request any bigger or smaller than
> the last request). Then if we need the final size for anything we can
> add it without further confusion.
> 
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch