[Intel-gfx] [PATCH] drm/i915: Use symbolic irqreturn for ->hpd_pulse

[Jani Nikula]

On Mon, 09 Feb 2015, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Fri, Feb 06, 2015 at 08:49:12PM +0200, Ville Syrjälä wrote:
>> On Fri, Jan 23, 2015 at 06:00:31AM +0100, Daniel Vetter wrote:
>> > Self-explanatory code is better code.
>> 
>> This causes the VDD off -> HPD -> VDD on -> VDD off -> HPD ... cycle to
>> make another appearance on my BSW. Looks like you forgot to convert one return
>> in intel_dp_hpd_pulse():
>> 
>> @@ -4499,7 +4499,7 @@ intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd)
>>                  */
>>                 DRM_DEBUG_KMS("ignoring long hpd on eDP port %c\n",
>>                               port_name(intel_dig_port->port));
>> -               return false;
>> +               return IRQ_HANDLED;
>>         }
>>  
>>         DRM_DEBUG_KMS("got hpd irq on port %c - %s\n",
>
> Oh dear that's rather bad. Can you please supply a full patch so that Jani
> can take it up for dinf? Free Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> fwiw (which isn't much).

*facepalm* from the "reviewer" here too.

Ville, please change that early return to a "goto out" maybe?


BR,
Jani.



> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch

-- 
Jani Nikula, Intel Open Source Technology Center