[Intel-gfx] [PATCH] drm/i915: Stop requesting error_state reports.

[Chris Wilson]

On Tue, Feb 10, 2015 at 11:27:30AM -0800, Rodrigo Vivi wrote:
> These error states are great to know gpu state when it hangs.
> 
> But since we don't have automated tools to do analysis we are
> facing much noise on bugzilla with end users reporting just
> because "log asked to", while gpu reset worked and users probably
> never notice any screen issue.

Other than the corruption and the machine stuttering for a number of
seconds, sometimes many times per hour. I think that justifies having
some form of user visible message about what just happened.

> Most of these reportes don't know
> when it happened or how to retrigger the issue and somethimes
> they are not even on the mood to retest again.

It is the goal of the error state to capture exactly enough information
for post-mortem analysis. As you feel it is inadequate, please augment
it.
 
> So, let's minimize our and end user's noise and protect this smaller
> message with drm.debug. Developers, OSVs and users that face
> real screen issue (should) always enabled this debug and will see
> the message when error state got dumped.

I don't think the tradeoff is worth it. If you have automatic bug
reporting, then yes you can remove the plea to have the user do it, but
not before.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre