[Intel-gfx] [PATCH i-g-t] lib/chipset: Cache devid

Chris Wilson chris at chris-wilson.co.uk
Tue Feb 10 14:28:22 PST 2015


On Tue, Feb 10, 2015 at 10:59:16PM +0100, Daniel Vetter wrote:
> Chris Wilson complained that this adds a lot of noise to the test
> startup when full debugging is enabled, so let's cache it. We can do
> that since there's only ever one intel gpu in a given system.
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>

Couldn't we move the devid cache to lib/drmtest.c::is_intel() ?

Then I wonder what to do about the getenv override. Whether that is also
better inside is_intel().
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list