[Intel-gfx] [PATCH i-g-t 05/17] lib/ioctls: make gem_context_set/get_param infallible

Daniel Vetter daniel at ffwll.ch
Wed Feb 11 00:42:29 PST 2015


On Tue, Feb 10, 2015 at 09:54:46PM +0000, Chris Wilson wrote:
> On Tue, Feb 10, 2015 at 07:05:48PM +0100, Daniel Vetter wrote:
> > We have separate require checks already, so these failing is a bug in
> > the test logic.
> 
> That makes it impossible to use the wrappers to test the ioctl though.

Yes. Ime for ioctl testing you want to open-code it anyway so that all the
nasty "put garbage into reserved stuff and padding" tests are possible.
And for those cases where we want to share a bit of code we just add an __
variant which does the usual -errno integer return value. Then the
infallible ones just wrap that in igt_assert/skip.

So just aligning with the usual style.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the Intel-gfx mailing list