[Intel-gfx] [PATCH 3/4] drm: use drmIoctl everywhere

Daniel Vetter daniel at ffwll.ch
Wed Feb 11 06:34:47 PST 2015


On Wed, Feb 11, 2015 at 01:13:26PM +0000, Emil Velikov wrote:
> On 11 February 2015 at 11:42, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> > Well just core drm. All the other callers in there that still use
> > direct calls to ioctl have some custom retry logic already, so should
> > be good already.
> >
> Afaics intel/intel_bufmgr_gem.c has one instance, plus most of the tests.

That one is in set_tiling and because of a very peculiar retry semantics
of that specific ioctl. Don't ask ;-)
> 
> > freedreno/kgsl ahas all the other bare ioctl calls, dunnot what to do
> > about that.
> >
> s/ahas/has/ if you choose to keep this note.

Already reworded since kgsl is the blob library and so not a drm thing.

Thanks for your review.
-Daniel
> 
> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
> 
> -Emil

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the Intel-gfx mailing list