[Intel-gfx] [PATCH 1/7] drm/i915/skl: Added new macros

Goel, Akash akash.goel at intel.com
Tue Feb 17 07:20:53 PST 2015


Thanks for the review. Agree it's not an appropriate name. 
Please kindly suggest one.  
'GT_TIME_COUNTER_UNITS_FROM_PERIOD' ??

Best regards
Akash

-----Original Message-----
From: Lespiau, Damien 
Sent: Tuesday, February 17, 2015 8:10 PM
To: Goel, Akash
Cc: intel-gfx at lists.freedesktop.org
Subject: Re: [PATCH 1/7] drm/i915/skl: Added new macros

On Fri, Feb 06, 2015 at 08:26:32PM +0530, akash.goel at intel.com wrote:
> +#define FREQ_1_28_US(us)	(((us) * 100) >> 7)
> +#define FREQ_1_33_US(us)	(((us) * 3)   >> 2)
> +#define GT_FREQ_FROM_PERIOD(us, dev) (IS_GEN9(dev) ? \
> +				FREQ_1_33_US(us) : \
> +				FREQ_1_28_US(us))

I'm not sure why you call that GT_FREQ when it looks like a time for evaluation intervals.

--
Damien


More information about the Intel-gfx mailing list