[Intel-gfx] [PATCH] drm/i915: logical-not-parenthesis gcc 5.0 fixes

[Jani Nikula]

On Mon, 23 Feb 2015, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Sun, Feb 22, 2015 at 08:10:11PM +0100, François Tigeot wrote:
>> * Originally added by John Marino in DragonFly's eecf6c3c3b6f7127edd8b8f8c2a83e2f882ed0da
>>   commit.

...

>> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>> index 3b0fe9f..91264b2 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -13299,7 +13299,7 @@ intel_check_plane_mapping(struct intel_crtc *crtc)
>>  	val = I915_READ(reg);
>>  
>>  	if ((val & DISPLAY_PLANE_ENABLE) &&
>> -	    (!!(val & DISPPLANE_SEL_PIPE_MASK) == crtc->pipe))
>> +	    (!!( (val & DISPPLANE_SEL_PIPE_MASK) == crtc->pipe) ))
>
> That's wrong.

Indeed; this has introduced a bug in DragonFly. Not that I care, but so
you know.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center